Feature request: Physical bank

[VreyaViress]

https://i.imgur.com/CPjaa0l.png (Towny bank using Gringotts as an example)

Currently, Bag Of Gold's bank system is kind of virtual, as the money deposited is somehow stored in the server instead, stopping being physically available once in there.

It would be, of course, pretty easily to simply have a bunch of gold blocks stored at some building, when using Gringotts Style option in the config. However, you could not know how much money you actually have.

Therefore, a way to either use a chest where you can deposit the Gringotts style blocks, or maybe (even better) a way for the Bag of Gold plugin to detect the value of the blocks stored on the ground at some building, would keep the physical impression while, at the same time, allowing you to store the money somewhere else that isn't your inventory.

On the other hand, there's this plugin Towny, which has a bank fro plot claiming porpuses. On Gringotts, you can manage the money stored in that bank through signs. However, when using Bag of Gold, the physical money you once had in your inventory, turns virtual once you deposit it in the town's bank. My suggestion here would be to either have some kind of add-on to make a new plot type called "Bank", where every block configured with Bag of Gold Gringotts style would be counted for the amount of money available on your town's bank.

[Rocologo]

So I understand that you would like to have a Bank where the money is stored safely as items/blocks.

But why dont you store the items in a protected chest then? I dont understand what the difference is?

Or you could use ShopArea and make small rooms (banks) where your players can buy a room (a kind of "safe", this is actually my own plan for my server - making a bank with "ShopArea rooms". The player can the buy a room and store their money in the room.

[VreyaViress]

The point is making it quantifiable.

Make it so you can know how much money you have stored in a physical bank. Also, making Towny's bank physical.

[AnthonyPaulO]

https://i.imgur.com/CPjaa0l.png (Towny bank using Gringotts as an example)

Currently, Bag Of Gold's bank system is kind of virtual, as the money deposited is somehow stored in the server instead, stopping being physically available once in there.

It would be, of course, pretty easily to simply have a bunch of gold blocks stored at some building, when using Gringotts Style option in the config. However, you could not know how much money you actually have.

Therefore, a way to either use a chest where you can deposit the Gringotts style blocks, or maybe (even better) a way for the Bag of Gold plugin to detect the value of the blocks stored on the ground at some building, would keep the physical impression while, at the same time, allowing you to store the money somewhere else that isn't your inventory.

On the other hand, there's this plugin Towny, which has a bank fro plot claiming porpuses. On Gringotts, you can manage the money stored in that bank through signs. However, when using Bag of Gold, the physical money you once had in your inventory, turns virtual once you deposit it in the town's bank. My suggestion here would be to either have some kind of add-on to make a new plot type called "Bank", where every block configured with Bag of Gold Gringotts style would be counted for the amount of money available on your town's bank.

Wouldn't the Banker serve the same purpose? I had the same gripe when I first used the mod but then realized it supported an actual banker via '/bag banker create' command. I build a bank structure and create my banker inside and 'presto', I now have a physical bank I can go to in order to deposit and withdraw money, makes it all seem real rather than virtual via commands.

[Rocologo]

I like the idea about physical money in the bank. I have thought about a solution where chests is vaults. One chest per player and the chest can only be opened by rhe owner. A chest protection plugin like LWC could be used for this.

And maybe a Worldguard region to define the bank area.

[rackgaming]

I still think we need this in 2022.

[rackgaming]

but I use griefprevention also

[Rocologo]

Hi. I still like the idea about a physical bank. But I not sure how the concept should be and how the bank should look like.

[rackgaming]

Well I am currently talking with XVaults and he wants to implement support so that a chest with a sign having [vault] can be a personal bank inside a land claimed area

[rackgaming]

So he wants to add bagofgold support

[rackgaming]

So that players can put their bagofgold inside a vault claimed chest in his plugin and the chest can be opened to access the bank money

[rackgaming]

Their personal bank money but I think that is the concept

[Rocologo]

If he needs help I will gladly help

[rackgaming]

Gringotts basically uses real minecraft items like emerald diamond whatever you choose

[rackgaming]

Thats the physical item part from what op is asking

[Rocologo]

I know how Gringotts works. :-)

[Rocologo]

BagOfGold can be configured to work like Gringotts

[Rocologo]

Im still think that I would be able to make a physical bank using a Workdguard region containing chests for storage of the bags and and the banker or the signs inside the region would access the chests/bags.

[rackgaming]

OH! I see what OP is saying my bad, sorry. Basically the BagOfGold on ground in a towny ect is still counted as bank money
ya sorry i was watching my phone so i did not understand what was being said here but ya that would be great. show off your riches inside your own homebase

[Rocologo]

I worried about one thing. How should players who is not playing on the server anymore be handled in a physical bank be handled? After some time the bank will be filled will money from players who is not on the server any more.

[rackgaming]

Well if they leave, have the items unload but stored in player data then when they come back it loads their currency back in

[rackgaming]

The staff should have perms to remove bank currency from a player

[rackgaming]

Or the towny owner should have perms to remove residents bank currency and it goes back to the original resident and if they leave that towny the money should go back to the original players hand

[Rocologo]

But if the items in the bank is unloaded what is the point then? Then you make them virtual again? You make me think about what the point is? Why store the bags in a bank, if the disapear when the player leaves and nobody can see or interact with the money in the bank?

What is the used case for the player when he enter the Bank?

[Rocologo]

I mean if you cant see the money in the bank, why then store them in a chest in a bank ?

[rackgaming]

Well we're talking about someone who is never coming back. Am a bit confused if we're talking about self owned land claims or towny and faction

[Rocologo]

I am a bit confused as well :-)

At the moment we are brainstorming. I will not start coding until I am sure that we somehow agree about the solution and agree about how this should work when you are a Player and when you are Admin.

[rackgaming]

Well what do you know, thank you for letting me know because on the page of BagOfGold, it just states Citizens2 lol.

??? but it does not say a Paid version? :-)

Well some people don't understand that because they'll just go to that page and it will say $10.00 then they think oh BOY, time to get out my wallet :D

[rackgaming]

Also why don't you make a discord?? Wouldn't it be easier instead of spamming the github page?

[Rocologo]

Well what do you know, thank you for letting me know because on the page of BagOfGold, it just states Citizens2 lol.

??? but it does not say a Paid version? :-)

Well some people don't understand that because they'll just go to that page and it will say $10.00 then they think oh BOY, time to get out my wallet :D

I have never paid for a plugin and I dont want to and mine has always been free. This is a hobby for me. Its free when you download Citizens from theit Jenkins server. http://ci.citizensnpcs.co/job/Citizens2

[Rocologo]

Also why don't you make a discord?? Wouldn't it be easier instead of spamming the github page?

I have a Discord Server, but I dont have the time to support and answer alot of questions :-D

[rackgaming]

For such an advanced plugin, I am actually pretty glad that you are making this for free but I'd still donate some money in a heart beat if there was a donation page, you definitely deserve it for your hard work.

[rackgaming]

Ah well it's not on the page and time doesn't matter as long as people get help, they can just be patient so I'd still like to join it.

[Rocologo]

And I am always happy when someone makes a donation and I can tell you I spend ALOT of time on this :-)

[rackgaming]

There ya go, buddy! Check your paypal ^^

[Rocologo]

There ya go, buddy! Check your paypal ^^

You found me :-D

[rackgaming]

Am a bit confused because I tried creating a bank NPC on the free version and it did not do anything but give a giant error.

[Rocologo]

Am a bit confused because I tried creating a bank NPC on the free version and it did not do anything but give a giant error.

Im pnly using the free version. It is important that you use a version which works on your server version. Im on 1.19.2 so I can use the newest version.

[rackgaming]

I'm on paper 1.19 using the latest build 4 days ago.

[Rocologo]

I'm on paper 1.19 using the latest build 4 days ago.

Check your server log. Does Citizens2 enable without errors ?

[rackgaming]

Citizens2 is the one having the error, posted it on their discord. Waiting for a response.

[Rocologo]

I also notice that you use Paper-Spigot Im always using Spigot MC. I dont know if there is a difference.

[rackgaming]

People usepaper spigotbecause its more optimized then spigot

[rackgaming]

Essentially their the same but one is less performance impacted

[rackgaming]

I spoke with the devs of NPC and they said that they do not support non patched versions which means, I will unfortunately have to update to 1.19.2 paper MC for the NPC's to work. Which is a good thing to note on the spigot page.

As in 1.19 spigot and paper MC are not supported.

[Rocologo]

it shouldnt be a big problem to update to 1.19.2 you will find the most plugins which works on 1.19 also works on 1.19.2 or has been updated.

[Rocologo]

I have actually started to make the code for the the Bankvault features :-)

Now I have to decide

1. how the admin should create the Bank and define which chests are used as Bankvaults inside the Bank.
2. How the players should claim a chest and use it as a bankvault for his bags.

I can either use commands like
/bag bank create bankname (difining the area)
/bag vault create (admin define the chest as bankvault)
/bag vault remove (admin remove the bankvault from the bank)
/bag vault claim (the player claims the bankvaukt)
or the player claims a chest first time he moves a bag into the Chest.
or the player could claim the chest by placing a sign on the chest with [bankvault]

I think that it should have a cost to claim a chest (price defined in config)

Also I think about making a sign placed over the chest or attached to the chest, with some information like
[Bankvault]
ownername
balance
last seen date (if I can find this)

what do you think?

[Rocologo]

I think I prefer a solution where the admin place a sign on top of the Chest, but Im not sure because it limits the admin posibility to make his design

[rackgaming]

Bank defined area sounds good

[rackgaming]

And for player owned vaults [bankname vault] namehere balance lastseen is good on front of chest

[rackgaming]

So just make it when they place that sign on their chest its claimed to their name

[Rocologo]

I got another idea.

The admin/owner could place a NpC inside the bank, and if the player has no vault, the NPC could be used to claim a vault and then tell the player which vault number he got.

I could probably make the NPC to walk to the vault and show the player where it is. Maybe!

[rackgaming]

New issue: BagOfGold is not showing up on bedrock properly.

[Rocologo]

New issue - New ticket! So we dont get confused. If you are using Geyser,then open a ticket at their place. I think it is Geyser which does not support custom playerheads. I think I read that somewhere, and therefore it does not work :-(

Im still working on the Physical bank feature, but it takes time, because Xmas is very busy and more important :-)

[Rocologo]

Look here: GeyserMC/Geyser#1454

It seems to be a Bedrock limitation.