Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When removing assets it does not also remove then from the subwindow. #69

Open
develroo opened this issue Sep 8, 2017 · 2 comments
Open
Assignees
Milestone

Comments

@develroo
Copy link

develroo commented Sep 8, 2017

Build Status

#Your configuration:
Rolisteam version: 1.8.2ubuntu2
Operating System and version:
-[ Debian 9.0 + testing amd64 ]

Rolisteam Setting:
-GM and Server / GM and Client / Player and Client / Player and Server
All of the above

#What did you do ? (Explain each step from starting rolisteam to the issue)

  • Add maps, character sheets, notes or any assets to a table everything is as expected. However when you remove them from the resource list it remains in the subwindow list cluttering it up.

#What did you expect to see ? (Make sentences and explains in details with words)

  • Subwindow should reflect active assets not legacy ones.

#What did you get instead ? (Describe in details the issue)

  • Removed assets are show in the subwindows list.

Example screen-shot here.

https://imgur.com/a/5DiIC

@obiwankennedy
Copy link
Member

When you click on the subwindow item, the assets appears right ? or Does it crash ?

I think the main issue here is the goal of the resources manager.

The resources manager allows you to save reference to assets. Removing assets from it means "I don’t need that assets in my campaign." But you still need it in this session. So the assets stays in your current session.

Perhaps the solution here is to add a new action on the session manager to remove the assets from the resources manager and from the session as well.

So, I will put your request as new feature.

@obiwankennedy obiwankennedy self-assigned this Sep 9, 2017
@obiwankennedy obiwankennedy added this to the v1.9.0 milestone Sep 9, 2017
@develroo
Copy link
Author

develroo commented Sep 9, 2017

When you click on the subwindow item, the assets appears right ? or Does it crash ?

No as you correctly surmise the asset appears back as if it was never removed. This is for all connected players as well which is where the confusion happens. If , as the GM , you remove an asset form the resources list I think the assumption should be you want to remove it from the session as well. (otherwise why have the ability to remove it at all)

I never really thought of it as a feature but sure if you want to add it as one why not?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants