Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fetchChemicals method #77

Closed
yunchae-kim opened this issue Sep 20, 2023 · 0 comments · May be fixed by #79
Closed

Create fetchChemicals method #77

yunchae-kim opened this issue Sep 20, 2023 · 0 comments · May be fixed by #79
Assignees
Labels
enhancement New feature or request

Comments

@yunchae-kim
Copy link
Contributor

Currently we don't have a method that fetches the list of chemical ids by the 'type of id (ex. CasRN, DTXSID).'
The goal is to create a method called fetchChemicals which takes input parameter of 'type of id (ex. CasRN, DTXSID)' and 'list of ids' to return a list of chemicals matching those id list input.

TODO:

  • Create method fetchChemicals
@yunchae-kim yunchae-kim added the enhancement New feature or request label Sep 20, 2023
@yunchae-kim yunchae-kim self-assigned this Sep 20, 2023
yunchae-kim added a commit that referenced this issue Sep 26, 2023
This update makes the following changes:
- Created method fetch_chemicals to fetch list of chemical data matching
the specific type/value of property input.
- Created test for fetch_chemicals.
- Updated .gitignore to ignore pushing test result files used
specifically for local pytest.
@yunchae-kim yunchae-kim linked a pull request Sep 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant