Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nil to be set as default currency #698

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sirwolfgang
Copy link

This is a part of fixing the #697

sunny
sunny previously approved these changes May 2, 2024
Copy link
Contributor

@sunny sunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Can you add an entry to the CHANGELOG as well? 🙏🏻

spec/dummy/db/schema.rb Outdated Show resolved Hide resolved
@@ -9,7 +9,7 @@ platforms :jruby do
end

platforms :ruby do
gem "sqlite3"
gem "sqlite3", '~> 1.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirwolfgang sirwolfgang requested review from tagliala and sunny May 14, 2024 17:33
@sirwolfgang
Copy link
Author

This is blocked by RubyMoney/money#1095

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants