Fix deprecation warning when running specs #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tagliala
changed the title
`raise_error` better clarifies what is expected from specs and is also shorter - `ArgumentError` and `TypeError` are errors - `DifferentCurrencyError`, `UndefinedSmallestDenomination`, and `UnknownRate` inherit from `Error` - `UnknownCurrency` inherits from `ArgumentError`
tagliala
force-pushed
the
chore/1076-fix-deprecation-warning
branch
from
2d99767 to
042c855
Compare
|
ty |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also,
raise_errorbetter clarifies what is expected from specs and is alsoshorter
ArgumentErrorandTypeErrorare errorsDifferentCurrencyError,UndefinedSmallestDenomination, andUnknownRateinherit fromErrorUnknownCurrencyinherits fromArgumentErrorClose #1076
Requires #1078 to pass CI