Require Ruby 3.1 and fix bigdecimal requirement #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@semmons99 failures depends by the fact that i18n does not set a minimum required ruby version and is using a non-compatible version on specs. I can fix it with the Gemfile, or I can set the minimum version to 2.5 (or even newer) |
tagliala
force-pushed
the
chore/1085-1086-bigdecimal-ruby-version
branch
from
5e52bba to
cf74627
Compare
|
I am open to whichever you think is best
|
|
I do not like dropping compatibility just for sake of dropping compatibility, but given that 2.7 is in EOL since Mar 2023 an 3.0 will EOL in 2 weeks, I would drop anything below 2.7 |
|
I think we should drop 3.0 and hold release for 2 weeks. Make our lives easier.
|
tagliala
force-pushed
the
chore/1085-1086-bigdecimal-ruby-version
branch
from
cf74627 to
f5c46fc
Compare
|
Much better, will do that |
Drop all EOL Ruby versions Close RubyMoney#1086
- bigdecimal installs and works fine on all supported ruby versions - The condition was checking for ruby version to be greater than 6.19, which will not happen soon - The condition is also evaluated on `rubygems`, and it is not correct Close RubyMoney#1085
tagliala
force-pushed
the
chore/1085-1086-bigdecimal-ruby-version
branch
from
f5c46fc to
815b618
Compare
tagliala
changed the title
|
This should be fixed by an admin in Settings => Branches => Branch protection rules 
|
semmons99
approved these changes
Mar 13, 2024
|
fixed. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set minimum Ruby version to 3.1
Drop all EOL Ruby versions
Close #1086
Remove conditional on bigdecimal
which will not happen soon
rubygems, and it is not correctClose #1085