Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deletion of scratch org optionnal #6

Open
fprovot opened this issue Nov 17, 2023 · 2 comments · May be fixed by #7
Open

Make deletion of scratch org optionnal #6

fprovot opened this issue Nov 17, 2023 · 2 comments · May be fixed by #7

Comments

@fprovot
Copy link

fprovot commented Nov 17, 2023

Hello @RupertBarrow
Testing deployment on scratchorg using rupertbarrow/cumulus-action-run-flow-scratch@v1 always create and delete the scratch org.
I am installing a package in pre actions, thus it takes too much time.
Can you add an option that allow not to delete it?
Thanks

@fprovot
Copy link
Author

fprovot commented Nov 17, 2023

Thanks I saw the change (I did it also in a local branch I made). I will use this version 6 on my new action which is a copy of the ci_release for immediate scratch org tests.

@fprovot
Copy link
Author

fprovot commented Nov 17, 2023

Still having strangly
Deleting scratch org with command: sfdx force:org:delete -p
-u [email protected]
[11/17/23 17:19:48] Successfully marked scratch org
[email protected] for deletion

While using
- name: RUN SALESFORCE TESTS -----------------------------------------------------------
#uses: rupertbarrow/cumulus-action-run-flow-scratch@v1
uses: rupertbarrow/cumulus-action-run-flow-scratch@6-make-deletion-of-scratch-org-optionnal
with:
dev-hub-auth-url: "${{ secrets.SFDX_AUTH_URL_DEVHUB }}"
cumulusci-service-github: "${{ secrets.CUMULUSCI_SERVICE_GITHUB }}"
flow-name: "ci_feature"
org-name: ${{ matrix.orgname }}
cumulusci-version: "3.76.0"
sfdx-version: "7.205.6"
delete-scratch-org: false

Not sure where it comes from. Will see that next week...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant