Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No dangerous_statements #53

Closed
wants to merge 5 commits into from
Closed

No dangerous_statements #53

wants to merge 5 commits into from

Conversation

albertmink
Copy link
Contributor

fixes #13

@albertmink albertmink marked this pull request as ready for review April 21, 2022 11:55
@albertmink albertmink requested a review from larshp April 21, 2022 11:55
@larshp
Copy link
Collaborator

larshp commented Apr 21, 2022

hmm, so I ended up excluding one file https://github.com/SAP/abap-file-formats-tools/blob/main/abaplint.jsonc#L4, which is the file with the dangerous statements, this one file is not checked for anything(as of now)

@albertmink
Copy link
Contributor Author

I see, then let's close the issue

@albertmink albertmink closed this Apr 21, 2022
@albertmink albertmink deleted the minka/dangerous_statement branch April 27, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp Awaiting requested review from larshp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable rule dangerous_statement
2 participants
@albertmink @larshp