Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed service key env var to AICORE_SERVICE_KEY #16

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Changed service key env var to AICORE_SERVICE_KEY #16

merged 5 commits into from
Aug 14, 2024
+16 −13

Conversation

CharlesDuboisSAP
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP commented Aug 14, 2024 •
edited
Loading

Context

Environment variables should be uppercase.

Feature scope:

  • Changed service key environment variable from aicore to AICORE_SERVICE_KEY

Definition of Done

  • Functionality scope stated & covered
  • Tests cover the scope above
  • Error handling created / updated & covered by the tests above
  • Aligned changes with the JavaScript SDK
  • Documentation updated
  • Release notes updated

@CharlesDuboisSAP CharlesDuboisSAP self-assigned this Aug 14, 2024
@CharlesDuboisSAP CharlesDuboisSAP merged commit 01c80eb into main Aug 14, 2024
3 checks passed
@CharlesDuboisSAP CharlesDuboisSAP deleted the AICORE branch August 14, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newtork newtork newtork approved these changes

@MatKuhr MatKuhr Awaiting requested review from MatKuhr

Assignees

@CharlesDuboisSAP CharlesDuboisSAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesDuboisSAP @newtork