Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load changes from workspace in Preview after deployment #2650

Merged
merged 6 commits into from
Dec 12, 2024

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Dec 3, 2024

#2648

  • After an Adaptation Project is deployed to the backend system, changes made after the deployment in the local workspace are no longer loaded when running the project in Preview.

@mmilko01 mmilko01 added bug Something isn't working preview-middleware @sap-ux/preview-middleware labels Dec 3, 2024
@mmilko01 mmilko01 requested a review from a team as a code owner December 3, 2024 13:08
Copy link

changeset-bot bot commented Dec 3, 2024

🦋 Changeset detected

Latest commit: 67b1ea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@heimwege heimwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code changes are straight forward
  • changeset ok
  • excellent test coverage
  • did NOT test locally but witnessed a test 🐱

@mmilko01 mmilko01 requested a review from testojs December 4, 2024 07:57
Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code changes look good
  • changeset OK
  • excellent test coverage
  • not tested manually

Copy link

sonarcloud bot commented Dec 12, 2024

@mmilko01 mmilko01 merged commit 77cf576 into main Dec 12, 2024
16 checks passed
@mmilko01 mmilko01 deleted the fix/2648/workspace-changes-preview branch December 12, 2024 16:37
devinea added a commit that referenced this pull request Dec 12, 2024
…g-message-_input

* origin/main:
  chore: apply latest changesets
  fix: load changes from workspace in Preview after deployment (#2650)
  chore: apply latest changesets
  fix(`odata-service-inquirer`): Apply additional messages to service selection prompt (#2693)
  chore: apply latest changesets
  Cleanup cf tests (#2690)
  chore: apply latest changesets
  fix: Manifest template for services (#2686)
  chore: apply latest changesets
  fix: mock os-name (#2689)
  chore: apply latest changesets
  fix: running test multiple times (#2685)
  chore: apply latest changesets
  fix(app-config-writer): add missing logger parameter for convert preview-config (#2687)
  chore: apply latest changesets
  Replace Keytar with @zowe/secrets-for-zowe-sdk (#2635)
  chore: apply latest changesets
  feat: Enhance extracted FLP prompts to support ADP scenario (#2610)
  chore: apply latest changesets
  feat: Ensuring UI5 2.x compliance for cards-editor-middleware Plugin (#2613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working preview-middleware @sap-ux/preview-middleware
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants