Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(odata-service-inquirer): Apply additional messages to service selection prompt #2693

Merged
merged 7 commits into from
Dec 12, 2024

Conversation

IainSAP
Copy link
Contributor

@IainSAP IainSAP commented Dec 11, 2024

#2692

  • Applies additionalMessages to serviceSelection prompt
  • Adds test to cover

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: b63efe8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sap-ux/odata-service-inquirer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IainSAP IainSAP self-assigned this Dec 11, 2024
@IainSAP IainSAP added the odata-service-inquirer @sap-ux/odata-service-inquirer label Dec 11, 2024
@IainSAP IainSAP marked this pull request as ready for review December 12, 2024 10:45
@IainSAP IainSAP changed the title Apply additional messages to service selection prompt fix(odata-service-inquirer): Apply additional messages to service selection prompt Dec 12, 2024
@IainSAP IainSAP changed the title fix(odata-service-inquirer): Apply additional messages to service selection prompt fix(odata-service-inquirer): Apply additional messages to service selection prompt Dec 12, 2024
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are clear and covered by tests
changeset ✅

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.
Appropiate tests and changeset.

Copy link

sonarcloud bot commented Dec 12, 2024

@IainSAP IainSAP merged commit ec1dc17 into main Dec 12, 2024
16 checks passed
@IainSAP IainSAP deleted the fix/2692/apply_service_selection_add_msgs branch December 12, 2024 12:35
devinea added a commit that referenced this pull request Dec 12, 2024
…g-message-_input

* origin/main:
  chore: apply latest changesets
  fix: load changes from workspace in Preview after deployment (#2650)
  chore: apply latest changesets
  fix(`odata-service-inquirer`): Apply additional messages to service selection prompt (#2693)
  chore: apply latest changesets
  Cleanup cf tests (#2690)
  chore: apply latest changesets
  fix: Manifest template for services (#2686)
  chore: apply latest changesets
  fix: mock os-name (#2689)
  chore: apply latest changesets
  fix: running test multiple times (#2685)
  chore: apply latest changesets
  fix(app-config-writer): add missing logger parameter for convert preview-config (#2687)
  chore: apply latest changesets
  Replace Keytar with @zowe/secrets-for-zowe-sdk (#2635)
  chore: apply latest changesets
  feat: Enhance extracted FLP prompts to support ADP scenario (#2610)
  chore: apply latest changesets
  feat: Ensuring UI5 2.x compliance for cards-editor-middleware Plugin (#2613)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
odata-service-inquirer @sap-ux/odata-service-inquirer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants