Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-components): Added logic for aria-invalid to UIComboBox depending on errorMessage #2697

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Thomas-Neuhauser
Copy link

@Thomas-Neuhauser Thomas-Neuhauser commented Dec 12, 2024

The Microsoft FluentUI library has an inconsistency where the ComboBox does not set aria-invalid to true or false for the input field in the render output.
We will open an issue in the FluentUI repo in parallel and for the time add this workaround on our side.

Copy link

cla-assistant bot commented Dec 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: ba24099

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants