You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Because the storefront is using @extend on classes that developers also use in their own codebase for the storefront.
This is the list that is causing trouble for selector sizes:\
This .modal-dialog ruleset will be added to all the places where .modal-dialog is extended in the original codebase.
See: https://webinista.com/updates/dont-use-extend-sass/ for a short explanation.
This leads to severe selector bloat in a lot of applications.
Tell us the version of Spartacus
Library version: 2211.25.x
To Reproduce
Steps to reproduce the behavior:
Create a new component
Add some styling inside the component that specifies/modifies the .btn or .modal-dialog selectors
Check the styling
Desktop (please complete the following information):
N / A
Smartphone (please complete the following information):
N / A
Solution
Solution would be to only use extend on placeholders, not actual classes.
Search for @extend . in the codebase to see the offenders.
The text was updated successfully, but these errors were encountered:
Describe the bug
Because the storefront is using
@extend
on classes that developers also use in their own codebase for the storefront.This is the list that is causing trouble for selector sizes:\
For example, when a developer writes something like the following:
This
.modal-dialog
ruleset will be added to all the places where .modal-dialog is extended in the original codebase.See: https://webinista.com/updates/dont-use-extend-sass/ for a short explanation.
This leads to severe selector bloat in a lot of applications.
Tell us the version of Spartacus
To Reproduce
Steps to reproduce the behavior:
.btn
or.modal-dialog
selectorsDesktop (please complete the following information):
N / A
Smartphone (please complete the following information):
N / A
Solution
Solution would be to only use extend on placeholders, not actual classes.
Search for
@extend .
in the codebase to see the offenders.The text was updated successfully, but these errors were encountered: