Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@sapui5/ts-types-esm - SmartTable.getTable should return a sap.m.Table #316

Open
DetachHead opened this issue Nov 30, 2021 · 1 comment
Open
Labels
types ES modules types (recommended)

Comments

@DetachHead
Copy link

but its return type is object

    /**
     * returns the internally used table object
     */
    getTable(): object;

(i couldn't find where SmartTable was defined in https://github.com/SAP/openui5)

@codeworrior
Copy link
Member

"object" is not the best choice, indeed. But it's also not sap.m.Table. It rather should be sap.m.Table | sap.ui.table.Table | sap.ui.table.TreeTable | sap.ui.table.AnalyticalTable. Strictly spoken, the last two are not necessary as they are subclasses of sap.ui.table.Table, but explicitly naming them might help to understand the behavior of the getTable method better.

You can't find SmartTable in openui5 as it is not part of it. The sap.ui.comp library is only part of the bigger SAPUI5 package. I'll forward this issue internally to the corresponding colleagues.

@petermuessig petermuessig added the types ES modules types (recommended) label Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
types ES modules types (recommended)
Projects
None yet
Development

No branches or pull requests

3 participants