Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new dto encapsulating mapping and similaritites and refactor functions #20

Open
3 tasks
tiadams opened this issue Sep 4, 2024 · 2 comments
Open
3 tasks
Assignees
Labels
enhancement New feature or request refactoring Code that needs to be rewritten, without changing functionalities
Milestone

Comments

@tiadams
Copy link
Member

tiadams commented Sep 4, 2024

  • get_closest_mappings_with_similarities should be merged with get_closest_mappings and use the dto as response per default
  • get_terminology_and_model_specific_closest_mappings_with_similarities should be merged with get_closest_mappings
  • get_terminology_and_model_specific_closest_mappings can be removed

function signature should be as follows:

class MappingVectorMatch:

     mapping: Mapping
     similarity: Float
def get_closest_mappings(self, embedding_model_name, terminology_name=None, embedding, limit=5) -> List[MappingVectorMatch]:
    mapping_matches = []
    if terminology is None:
    # per default search over all terminologies
    else:
    # do terminology specific search
    return mapping_matches
@tiadams tiadams added enhancement New feature or request refactoring Code that needs to be rewritten, without changing functionalities labels Sep 4, 2024
@tiadams tiadams changed the title Create a new dto encapsulating mapping and similaritites and refactor fucntions Create a new dto encapsulating mapping and similaritites and refactor functions Sep 23, 2024
@tiadams
Copy link
Member Author

tiadams commented Sep 23, 2024

terminology_name should support types:

  • None -> search over all terminologies
  • String -> search for single terminology
  • [String] -> search for several terminologies

@tiadams
Copy link
Member Author

tiadams commented Sep 23, 2024

Makes sense to solve #21 before this to already use the new model class

@tiadams tiadams self-assigned this Oct 21, 2024
@tiadams tiadams added this to the v1.0.0 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Code that needs to be rewritten, without changing functionalities
Projects
None yet
Development

No branches or pull requests

1 participant