New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add function to Embedding model to get 'default' model #37

Open

tiadams opened this issue Oct 21, 2024 · 0 comments

Assignees

Labels

enhancement refactoring

Milestone

Member

tiadams commented Oct 21, 2024

We need a function to get a default mordel (as for now: MPNet) from the general Embedding model adapter.

why:

Currently, we use MPNet as default in several functions - if we want to exchange it we need to adapt all these functions
If we have the 'default' model function, we only need to replace it in one class (EmbeddingModel) without having to touch any other implementation

tiadams added enhancement refactoring labels

tiadams self-assigned this

tiadams added this to the v1.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment