Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Boccioli models #204

Open
6 tasks
JostMigenda opened this issue Aug 5, 2022 · 1 comment
Open
6 tasks

add Boccioli models #204

JostMigenda opened this issue Aug 5, 2022 · 1 comment
Assignees
Labels
SupernovaModel Implementing/correcting supernova model

Comments

@JostMigenda
Copy link
Member

During the SNEWS Collaboration Meeting, Luca Boccioli offered that we could add the simulations presented in his talk to SNEWPY.
I have a sample file and can write the necessary class; but with major changes to the SupernovaModel subclasses coming in #184, I’ll wait until that’s merged before completing this work & submitting the PR.

  • write registry class (in models.ccsn)
  • write loader class (in models.loaders)
  • add Zenodo ID to model_files.yml
  • add tests
  • add documentation and example notebook
  • (add support for this model to sntools)
@JostMigenda JostMigenda added the SupernovaModel Implementing/correcting supernova model label Aug 5, 2022
@JostMigenda JostMigenda self-assigned this Aug 5, 2022
@JostMigenda JostMigenda added this to the v1.4 milestone Sep 15, 2022
@mcolomermolla
Copy link
Collaborator

I will also have two new models that I will add (bubli2021, 3D MHD with different magnetic fields, and Mastrototaro2019 with "heavy" sterile neutrinos). I am in contact with both authors which were happy to share the data. I already have the data of the first and will get the second one soon. Let me know if I can help speed implementing what is needed before this.

@JostMigenda JostMigenda removed this from the v1.4 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SupernovaModel Implementing/correcting supernova model
Projects
None yet
Development

No branches or pull requests

2 participants