-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve generate_*
functions in snewpy.snowglobes
#209
Comments
We discussed this at the SNEWS telecon just now. A quick summary:
|
I like Andrey's suggestion for replacing the model_type and the transformation_type strings with class instances. With the current version of SNEWPY, flavor transformations which require additional parameters beyond the three vacuum mixing angles cannot be used unless the user dives into the generate_* functions. The two strings are included in the output filenames made by generate_* so we could modify both the flavor transformation and model classes by adding to each a to_tex() method which returns a string with the model or flavor transformation name. This is what is done in the Flavor class. |
Commenting on the second point: |
I think this should be planned for SNEWPY v2.0, so I'll change the milestone |
There are a couple of problems with the
generate_fluence
andgenerate_time_series
functions insnewpy.snowglobes
:generate_time_series
takes a number of bins or a bin duration, whereasgenerate_fluence
takeststart
andtend
which can be either a single value (corresponding to 1 bin) or a list of times (to create multiple bins of arbitrary lengths). As we recently saw on Slack, this even trips up us main developers sometimes.MixingParameters
presets #198) in the future.These issues are in principle independent; but they may all require backwards-incompatible changes to resolve, so I think we should try to tackle them in a coordinated fashion to minimise disruption. I have a rough idea how to do that, but want to coordinate with people working on the PRs mentioned above first.
¹ There is an optional
snmodel_dict
argument, which we could use to fit in all the physics parameters; but that would be quite awkward to use (and we’d still have the (then unused) file path as a required argument).The text was updated successfully, but these errors were encountered: