Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suites for the PR labels? #256

Open
Sheshuk opened this issue Jun 3, 2023 · 0 comments · May be fixed by #292
Open

Test suites for the PR labels? #256

Sheshuk opened this issue Jun 3, 2023 · 0 comments · May be fixed by #292
Labels
suggestion An idea that needs to be discussed/approved before starting implementaion

Comments

@Sheshuk
Copy link
Contributor

Sheshuk commented Jun 3, 2023

We have many tests now, which are being run on every PR.
While this is good for staying consistent, it makes a lot of unnecessary testing occuring: when some small correction is applied to documentation, we still check that all of our models are downloadable etc.
Probably there is a way to separate our test suites (like we already do for snowglobes, assigning pytest.mark in the test files) into separate sets, which would be run on the PR only when it has a certain label.
Something like that:

  • default tests for all PRs (some basic checks without many computations)
  • ModelRegistry - test that models can be downloaded
  • SNOwGLoBES - test rate calculation for some of the models (no need to download or use all of them)
  • SupernovaModel - test that all models can be instantiated etc.
  • documentation - try to build the documentation and probably provide it as an artifact of the PR
  • etc

Also probably there is a way to define the tests suites based on the files, modified in the PR.

This can reduce the usage of our runners, and address #238

Maybe you can add more ideas

@Sheshuk Sheshuk added the suggestion An idea that needs to be discussed/approved before starting implementaion label Jun 3, 2023
@Sheshuk Sheshuk linked a pull request Nov 24, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion An idea that needs to be discussed/approved before starting implementaion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant