Sheshuk/use test labels #292
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sheshuk
added
ModelRegistry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #256
Run the tests only if the given label is present.
Labels are:
SNOwGLoBES,ModelsRegistry,SupernovaModel- to test separate parts of the package.Adding label
test:Allforces a run of all existing tests (remove and add label again to repeat).Note:
Probably we should revise our tests. For example we don't need to run the tests on ALL models. I've introduced
pytest.mark.basefor testing basic functionality, so maybe we can mark couple of lightweight models asbase.Also still a lot of time is taken by downloading the SNEWPY in the first place, so I think we need to remove the model files from this repository.