New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Models: Remove deprecated arguments in constructors #307

Open

4 of 5 tasks

Sheshuk opened this issue Mar 1, 2024 · 0 comments · Fixed by #356

Open

4 of 5 tasks

Models: Remove deprecated arguments in constructors #307

Sheshuk opened this issue Mar 1, 2024 · 0 comments · Fixed by #356

Labels

Change interface ModelRegistry

Milestone

Contributor

Sheshuk commented Mar 1, 2024 •

edited by JostMigenda

Loading

Change the way the models are initialized.

Remove all @legacy_filename_initialization decorators in models/ccsn.py
Remove all deprecated input parameters
Remove workarounds for OConnor_2013 model:
Remove class OConnor_2013
Rename class _OConnor_2013_new to OConnor_2013

Remove lines with workaround for ModelsTable and documentation:

snewpy/python/snewpy/models/ccsn.py

Lines 245 to 248 in db4cc20

    
           OConnor_2013.__init__.__doc__=dedent(OConnor_2013.__init__.__doc__)+_OConnor_2013_new.__init__.__doc__ 
        
           #make sure that only the latest class is present in the models table 
        
           all_models.remove(OConnor_2013.__mro__[1]) 
        
           all_models.add(OConnor_2013)

The text was updated successfully, but these errors were encountered:

Sheshuk added this to the v2.0 milestone

Sheshuk added ModelRegistry Change interface labels

Sheshuk linked a pull request

that will close this issue

Remove deprecated arguments from SN model initialisers #356

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment