Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop deprecated usage of setup.py in builds #346

Open
JostMigenda opened this issue Jun 19, 2024 · 0 comments
Open

Stop deprecated usage of setup.py in builds #346

JostMigenda opened this issue Jun 19, 2024 · 0 comments
Assignees

Comments

@JostMigenda
Copy link
Member

JostMigenda commented Jun 19, 2024

Python packaging documentation explicitly warns that commands like python setup.py sdist bdist_wheel are deprecated and “MUST NOT be run anymore”.
Yet we use exactly that command in our publishing workflow.

The recommended replacement is the build module. This also ensures more reproducible builds by requiring build dependencies to be explicitly declared (in a pyproject.toml file) and building the project in an isolated virtual environment.

I’ve moved sntools over to build last year and found it worked very well and was a bit cleaner, too.
[Edit: See SNEWS2/BEMEWS#4 for another example.]

@JostMigenda JostMigenda self-assigned this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant