Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the SupernovaModel.get_*_spectra return the flux.Container objects #348

Open
3 tasks
Sheshuk opened this issue Jul 25, 2024 · 0 comments
Open
3 tasks

Make the SupernovaModel.get_*_spectra return the flux.Container objects #348

Sheshuk opened this issue Jul 25, 2024 · 0 comments
Labels
Change interface Breaking the backward compatibility suggestion An idea that needs to be discussed/approved before starting implementaion SupernovaModel Implementing/correcting supernova model
Milestone
v2.0

Comments

@Sheshuk
Copy link
Contributor

Sheshuk commented Jul 25, 2024

Make the SupernovaModel.get_*_spectra return the flux.Container objects, to make it consistent with the signature of the Supernova.get_flux method.

  • Change the implementation in SupernovaModel class
  • Update the example notebooks
  • Update tests
@Sheshuk Sheshuk added SupernovaModel Implementing/correcting supernova model suggestion An idea that needs to be discussed/approved before starting implementaion Change interface Breaking the backward compatibility labels Jul 25, 2024
@Sheshuk Sheshuk added this to the v2.0 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Change interface Breaking the backward compatibility suggestion An idea that needs to be discussed/approved before starting implementaion SupernovaModel Implementing/correcting supernova model
Projects
None yet
Milestone
v2.0
Development

No branches or pull requests
1 participant
@Sheshuk