Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(showcase): add playlist example #37

Merged
merged 2 commits into from
Jun 10, 2024
Merged

feat(showcase): add playlist example #37

merged 2 commits into from
Jun 10, 2024

Conversation

jboix
Copy link
Contributor

@jboix jboix commented May 30, 2024

Description

Introduces a playlist example using the @srgssr/pillarbox-playlist plugin.

In the example player is configured with the playlist plugins, and showcases how to fetch the media data fetches media data for a set of predefined video sources, loading them into the player's playlist with metadata.

Changes Made

  • Import a single stylesheet in the showcases to avoid vite optimisation to mixing the declared order of import.

@jboix jboix requested a review from amtins May 30, 2024 14:55
@jboix jboix self-assigned this May 30, 2024
Copy link

github-actions bot commented May 30, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-10 11:58 UTC

Introduces a playlist example using the `@srgssr/pillarbox-playlist` plugin.

In the example player is configured with the playlist plugins, and showcases how to fetch the media
data fetches media data for a set of predefined video sources, loading them into the player's
playlist with metadata.
@jboix jboix force-pushed the feat/playlist-demo branch from 8d9f5f7 to 6093155 Compare May 30, 2024 15:23
When importing stylesheets through the `<link>` tag, Vite optimizes multiple stylesheets and might
import them in a different order than declared. To avoid this problem, only one stylesheet is
imported per showcase, and the import is now done directly through SCSS import statements.

See vitejs/vite#4890
Copy link
Member

@amtins amtins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jboix jboix added this pull request to the merge queue Jun 10, 2024
Merged via the queue into main with commit b342a74 Jun 10, 2024
2 checks passed
@jboix jboix deleted the feat/playlist-demo branch June 10, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants