Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

fetchHistoryAcrossLinks does not work for branched packages #2

Open
dcermak opened this issue May 29, 2020 · 0 comments
Open

fetchHistoryAcrossLinks does not work for branched packages #2

dcermak opened this issue May 29, 2020 · 0 comments

Comments

@dcermak
Copy link
Collaborator

dcermak commented May 29, 2020

The following code fails:

await fetchHistoryAcrossLinks(this.con, { apiUrl, name: "rubygem-nokogiri", projectName: "Virtualization:vagrant"});

with an assertion:

AssertionError [ERR_ASSERTION]: Got an invalid history back, expected HEAD of linked package (devel:languages:ruby:extensions/rubygem-nokogiri) to be at undefined or 30cd3513bb3264cdf0350a5c398faf09 but got a356e1cb541160288f9465fc03c57617

This is caused by us using linkrev=base to fetch the expanded revisions in

`/source/${pkg.projectName}/${pkg.name}?expand=1&linkrev=base&rev=${rev.revisionHash}`

This works mostly, but it breaks if we have a package that has been branched, as then the following assertion fails:


This might be possible to fix by inserting the expanded revisions with and without linkrev=base into the commit cache.

dcermak added a commit that referenced this issue May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant