Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to remove indigenous and biological meat checks for code length #7

Open
sebastian-c opened this issue Sep 2, 2016 · 1 comment

Comments

@sebastian-c
Copy link
Contributor

The current implementation of removeIndigenousBiologicalMeat filters based on the length of the element code. This is worse than hardcoding as for someone not extremely familiar with all the codes, it's hard to work out why the restriction to 4 character exists.

This should be hardcoded as the various codes - a better solution than what's there now.

In addition, there's a warning and I don't see a reason for one to be thrown.

@mkao006
Copy link
Contributor

mkao006 commented Sep 2, 2016

This is because indigenous meat and biological meat have 5 digit element code, where as everything else has 4 digits. This is a flaw in design of the classification, and I agree it is a poor implementation but this should be fixed by the classification rather than being handled by the algorithm.

The reason the warning is issued is because indigenous meat and biological meat should be imputed, however, due to it's design, the imputation algorithm can not impute it and thus it is temporary removed until it can be handled in a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants