Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stacktrace field doesn't include causes, suppressed exceptions... #10

Open
johnedo1234 opened this issue May 21, 2015 · 2 comments
Open

Stacktrace field doesn't include causes, suppressed exceptions... #10

johnedo1234 opened this issue May 21, 2015 · 2 comments

Comments

@johnedo1234
Copy link

Causes and suppressed exceptions are absolutely critical to log.
@johnedo1234 johnedo1234 changed the title Stacktrace doesn't show causes, suppressed exceptions, etc... Stacktrace field doesn't include causes, suppressed exceptions... May 21, 2015
@johnedo1234
Copy link
Author

Looks like the impl is doing it's own writing of the stacktrace, and it leaves out all sorts of important info.

Seems simpler to just log the regular old Java stacktrace and leave it to the JDK to define what exactly that means.

@johnedo1234 johnedo1234 reopened this May 21, 2015
@johnedo1234
Copy link
Author

Submitted pull request with fix: #12

stacktrace field now includes the standard Java stacktrace in all its glory, even if the stacktrace is empty. KISS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnedo1234