Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve null handling in XML serializer #49

Open
sobolewskikamil opened this issue Jul 30, 2018 · 0 comments
Open

Improve null handling in XML serializer #49

sobolewskikamil opened this issue Jul 30, 2018 · 0 comments

Comments

@sobolewskikamil
Copy link
Collaborator

Problem description
During the course of JSON serializer implementation, we have understood there are serialization cases which are not handled properly in XML serialization logic. Null values in both Rule model and XML might not be handled and eventually result in NullPointerException being thrown. Those cases should be recognized and covered.
TIP:
Refer to JSON serializer code and null case tests.

Suggested solution

  • Recognize not covered null cases in XML serializer
  • Fix them and cover those changes with tests

Acceptance criteria

  • Tests are prepared
  • Code review is done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants