An AttributeValue may not contain an empty string

[SamVerschueren]

If some properties are empty strings, the insert/update fails. Should we filter out those empty strings or is it up to the user?

example

const key = {
    email: '[email protected]'
};

const values = {
    name: {
       firstName: 'Sam',
       name: ''
    }
};

User.insert(key, values).exec().catch(err => {
    //=> ExpressionAttributeValues contains invalid value: One or more parameter values were invalid: An AttributeValue may not contain an empty string for key :v_name
});

[SamVerschueren]

If the value is undefined or empty, remove it from the record.

http://docs.aws.amazon.com/amazondynamodb/latest/developerguide/Expressions.Modifying.html#Expressions.Modifying.UpdateExpressions.REMOVE

[mikedizon]

"Converting empty values to null is now an opt-in feature of the document client; you can pass a boolean convertEmptyValues option to the document client constructor to have it do so. I'll open a PR to improve the documentation of this feature."

aws/aws-sdk-js#833

[SamVerschueren]

Cool, we should definitely add it and I believe the best default is to make it opt-out and do this by default. Thanks for letting me know @mikedizon! Much appreciated.

[mikedizon]

If set, it seems to be setting blank values to true. Not sure what's causing it.

[SamVerschueren]

Might be a bug in the SdK itself. Will have a look at it tomorrow.

[AaronHarris]

Any update?

[SamVerschueren]

I looked at the issue thread regarding the convertEmptyValues. All it does is replace empty strings with null. Not sure if I like that behaviour... Have to test it out first. Most of the time, when I'm uncertain about some values, I run the data object through obj-clean.