Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gangType #1278

Open
Snorre98 opened this issue Jul 31, 2024 · 0 comments · May be fixed by #1506
Open

Rename gangType #1278

Snorre98 opened this issue Jul 31, 2024 · 0 comments · May be fixed by #1506
Assignees
Labels
backend Task related to backend. difficulty: easy Presumed to be a small task. frontend Task related to frontend.

Comments

@Snorre98
Copy link
Contributor

I feel it is unclear what "gangType" is, so I would suggest renaming gangType to "department".
So this issue would just make it more clear that GangType (would be Department) is not Gang, but is a parent of Gang.

This way we would have:

Department -> Gang -> Section

I dont think we represent Section yet, but might want to. This is unrelated to the issue.

Where Department instance would be "Driftende", with some Gang(s):
"MG", "KSG".

Another Department would be "Kunstneriske", with some Gang(s):
"SIT", "Pirum"

gangType might be refered to in a variation of ways in frontend so a good start for solving this would be to see where the endpoints which fetches gangTypes is used and rename the related values there.

@Snorre98 Snorre98 added backend Task related to backend. difficulty: easy Presumed to be a small task. frontend Task related to frontend. labels Jul 31, 2024
@Snorre98 Snorre98 self-assigned this Jul 31, 2024
@Frenje123 Frenje123 changed the title Rename gangType Rename gangType API Sep 3, 2024
@Frenje123 Frenje123 changed the title Rename gangType API Rename gangType Sep 3, 2024
@Frenje123 Frenje123 self-assigned this Sep 3, 2024
@Snorre98 Snorre98 removed their assignment Sep 30, 2024
@Frenje123 Frenje123 linked a pull request Oct 1, 2024 that will close this issue
@Frenje123 Frenje123 linked a pull request Oct 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Task related to backend. difficulty: easy Presumed to be a small task. frontend Task related to frontend.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants