Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneExplorer] Review the necessity of NodeMap #1718

Open
dayo09 opened this issue Oct 19, 2023 · 1 comment
Open

[OneExplorer] Review the necessity of NodeMap #1718

dayo09 opened this issue Oct 19, 2023 · 1 comment

Comments

@dayo09
Copy link
Contributor

dayo09 commented Oct 19, 2023

What?

NodeMap store path to node relationship.
To fulfill this functionality, node insertion/deletion should be related to all the file creation/deletion.

Initially it was introduced to keep node status in spite of hide/show status.
Let's check if it's really needed. Maybe nodes can be conditionally mapped to TreeItem, so that node map can be deprecated.


DRAFT: #1717

@dayo09
Copy link
Contributor Author

dayo09 commented Oct 19, 2023

Usages

It maps filesystem change to node

  • onDidDelete, onDidCreate, onDidChange
    • events take file uri. NodeMap helps getting the corresponding node instantly.
  • revealInOneExplorer
    • it also takes file uri. ditto.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant