Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when building from source on Windows (fix in pull request) #23

Open
stevereiner opened this issue Oct 12, 2024 · 0 comments
Open

Comments

@stevereiner
Copy link
Contributor

  1. When you build from source on Windows: "pip install ." or "pip install .[all]" get error:
    "Getting requirements to build wheel did not run successfully"
    "UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 4687: character maps to "

My redone pull request has the simple one line fix to setup.py to add utf-8
with open("README.md", "r", encoding="utf-8") as fh:
then building works

  1. It also in relik/version.py put in to up version to 1.0.8 for runtime Windows fix (change was after 1.0.7) and re-enabling allowing python 3.12

  2. took out for now was going to add windows os note to readme.md about needing your code in your main file in a function, need
    freeze_support() if code in exe, Llamma Index RelikPathExtractor / PropertyGraphIndex.from_documents ran about 8 times slower on Windows vs Linux. See relik-llama Still investigating if its not using cuda pytorch issue, a llamaindex issue, or relik, or just windows/python issue. Do see you have an example with langchain.py experimental RelikGraphTransformer to see if how it compares with llamaindex on windows.

  3. Note on pull request submit there is "lint would reformat" 21 files. I assume to ignore this. Also I apologize for not having a branch off of my fork main, so that the 2 file one change commit changes looks like 10 with syncing your main changes and me 3 readme changes / 3 undoing them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant