Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for how/why to use HttpServer #3

Open
bhudgeons opened this issue Jul 17, 2020 · 1 comment
Open

Documentation for how/why to use HttpServer #3

bhudgeons opened this issue Jul 17, 2020 · 1 comment

Comments

@bhudgeons
Copy link

This works great as a drop-in to provide Marshallers for Zio effects so that you can use them in routes. I also see that in the quickstart sample you're using HttpServer from this library. I have a feeling this is better than just dropping Zio effects into your "regular" Akka HTTP project. I'm trying to figure out why & how; I'll be happy to write up & share it when I can, but if there's an easy explanation, that would be great.

@vpavkin
Copy link
Contributor

vpavkin commented Jul 17, 2020

@bhudgeons Hi!
An easy explanation is that HttpServer is using ZLayer which fits nicely in a ZIO app. So if you're wiring your dependencies using ZLayer, our HttpServer would be a nice shortcut for you. Otherwise it's not that beneficial IMO.

I think it'll be a good addition to our readme, so a PR would be much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants