specialize ODEProblem
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the alg and prob were disagreeing about the chunksize (since prepare_alg thought we weren't FunctionWrappered since it didn't know we were an ODE yet)
|
A better fix would be to fix alg preparation on this alg? |
|
I wasn't sure how to do that properly since the only reason the alg prepare isn't working is because the function isn't in a function wrapper, but changing the prepare problem can't be done easily since that code is in scimlbase and doesn't know what we eventually might do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the alg and prob were disagreeing about the chunksize (since prepare_alg thought we weren't FunctionWrappered since it didn't know we were an ODE yet)