-
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate test failures #441
Conversation
389215d
to
1cfbe53
Compare
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 79.89% 73.68% -6.22%
==========================================
Files 16 22 +6
Lines 2567 2930 +363
==========================================
+ Hits 2051 2159 +108
- Misses 516 771 +255
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4444321
to
a9f86e0
Compare
This is to test whether it passes CI with an earlier version or not
3cb750c
to
a4139bb
Compare
This is to ensure all testsets run even if one fails as they are independent
a4139bb
to
34e64df
Compare
I investigated a bit about the Surrogates test failures and wanted to summarize them here:
So, I think (1) can be fixed but I am not sure what's happening with QuasiMonteCarlo currently. |
Okay, we should just bound QMC to 0.2.16, set the RNG seed for 1. Let's see how far that takes us. |
9a03973
to
ff5f158
Compare
lib/SurrogatesMOE/test/runtests.jl
Outdated
using Random | ||
Random.seed!(100) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use StableRNGs.jl
c8f4e4b
to
9c8f960
Compare
Using `BitArray(undef, n)` won't give all falses
beb5907
to
1ec6002
Compare
I think the reason MOE tests were failing spuriously as division between train and test data was not same each run because of using This is fixed in 6848450 julia> for _ in 1:10
@info sum(BitArray(undef, 150))
end
[ Info: 26
[ Info: 49
[ Info: 4
[ Info: 3
[ Info: 25
[ Info: 49
[ Info: 7
[ Info: 3
[ Info: 51
[ Info: 48 |
No description provided.