Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use XGBoost 2 #443

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Use XGBoost 2 #443

merged 2 commits into from
Sep 22, 2023

Conversation

sathvikbhagavan
Copy link
Member

No description provided.

@sathvikbhagavan
Copy link
Member Author

@ChrisRackauckas, this PR bumps XGBoost to 2.

All the tests pass except SurrogatesMOE as it uses the released version of SurrogatesRandomForest which uses XGBoost 1.5 which causes package conflict.
For the tests to pass, it needs a new release of SurrogatesRandomForest which requires this PR to be merged.
How do we want to go about this?

@ChrisRackauckas
Copy link
Member

Let's merge and then bump them both.

@ChrisRackauckas
Copy link
Member

We should change these to extensions, but 🤷

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review September 22, 2023 14:41
@ChrisRackauckas ChrisRackauckas merged commit 996f662 into SciML:master Sep 22, 2023
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sathvikbhagavan @ChrisRackauckas