Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gekpls.md using LHS Sampling #455

Closed
wants to merge 1 commit into from
Closed

Update gekpls.md using LHS Sampling #455

wants to merge 1 commit into from

Conversation

Spinachboul
Copy link
Contributor

@Spinachboul Spinachboul commented Dec 15, 2023

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa744e5) 78.12% compared to head (56f1f3e) 78.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #455   +/-   ##
=======================================
  Coverage   78.12%   78.12%           
=======================================
  Files          23       23           
  Lines        3154     3154           
=======================================
  Hits         2464     2464           
  Misses        690      690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sathvikbhagavan sathvikbhagavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what is the intention of this tutorial? If it is to show LHS Sampling is better for GEKPLS, we need to sample from other methods and show the test rmse for all and then draw a conclusion.

Also please follow the same pattern other tutorials are written. Include this file in pages.jl like in 0fc03e7 and all code blocks of the tutorial should be using @example syntax described in https://documenter.juliadocs.org/stable/man/syntax/#@example-block

@Spinachboul
Copy link
Contributor Author

@sathvikbhagavan
I apologize if my intention for using lhs was not clear! Lhs lets you sample data points in different dimensions with uniformity, so for a function like gekpls, I thought sampling points with more expanded space would give better accuracy.
I will surely test rmse for all the functions and then reach a proper conclusion.

And I will follow the same tutorial pattern for any changes in the future since I have just started contributing.

Thanks for the feedback!!

@Spinachboul Spinachboul closed this by deleting the head repository Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants