Input filename for shapefile.Reader() should be a string #2239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filename as a output of shpreader.natural_earth() is a pathlib.Path object. However, the function "shapefile.Reader()" requires the input filename to be a string.
JouleCai
changed the title
|
Maybe this should be applied only for PyShp < 2.3.0? GeospatialPython/pyshp#233 added support for path objects |
I think the solution here is for users to upgrade physhp to 2.3.0+? I'm not sure we should be version-gating on this. |
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
The input full path name for the function "shapefile.Reader()" should be a string. However, the file name get from e.g. natural_earth() is a pathlib.Path object. This causes an error when reading the data file.
Change
self._reader = reader = shapefile.Reader(filename)
to
self._reader = reader = shapefile.Reader(str(filename))
on line 136 in io/shapereader.py.