Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address failing tests in repo-review #462

Open
11 of 20 tasks
ukmo-ccbunney opened this issue Sep 19, 2024 · 1 comment
Open
11 of 20 tasks

Address failing tests in repo-review #462

ukmo-ccbunney opened this issue Sep 19, 2024 · 1 comment
Labels
New: Issue Highlight a new community raised "generic" issue Type: Infrastructure

Comments

@ukmo-ccbunney
Copy link
Contributor

ukmo-ccbunney commented Sep 19, 2024

PR #456 added repo-review as a pre-commit hook using the sp-repo-review plugin (https://pypi.org/project/sp-repo-review/)

Several of the checks are failing for the cf-units repository (expected). The failing tests are currently set in an ignore list in pyproject.toml to avoid failures in the workflow, but it would be good practice if we could address them:

Test

We may decide some checks are not relevant, in which case they can be removed from this above TODO list and left in the ignore list in pyproject.toml

@ukmo-ccbunney
Copy link
Contributor Author

Several tests resolved in #522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New: Issue Highlight a new community raised "generic" issue Type: Infrastructure
Projects
Status: No status
Development

No branches or pull requests

1 participant