-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Splitattrs ncsave redo commonmeta #5420
Closed
pp-mo
wants to merge
25
commits into
SciTools:FEATURE_split_attrs
from
pp-mo:splitattrs_ncsave_redo_commonmeta
Closed
Splitattrs ncsave redo commonmeta #5420
pp-mo
wants to merge
25
commits into
SciTools:FEATURE_split_attrs
from
pp-mo:splitattrs_ncsave_redo_commonmeta
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## FEATURE_split_attrs #5420 +/- ##
=======================================================
- Coverage 89.41% 89.30% -0.12%
=======================================================
Files 89 89
Lines 22500 22595 +95
Branches 5396 5423 +27
=======================================================
+ Hits 20119 20179 +60
- Misses 1636 1667 +31
- Partials 745 749 +4
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MISTAKE - replaced by pp-mo#77
just testing
provisional changes to common-metadata to accommodate split attribute dictionaries
No new function yet -- just to see if it breaks any existing tests
Will need additional tests for how this actually functions with split-attr testcases
Consult Iris pull request check list