Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard-names to #82 + add table version in std_names.py #5423

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Aug 15, 2023

Updating the standard-names table to latest version 82

Also, since it was one of the requests in #5255, I have added a little piece of code to include the table version in the file header + provide it as a public global variable.
(and a silly little test for that)

@pp-mo pp-mo requested a review from HGWright August 15, 2023 13:04
@pp-mo
Copy link
Member Author

pp-mo commented Aug 15, 2023

Ping @HGWright can you take this on ??
This is a standard thing in progress toward a new release (3.7)

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (915c1f4) 89.37% compared to head (7e481b9) 89.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5423   +/-   ##
=======================================
  Coverage   89.37%   89.37%           
=======================================
  Files          89       89           
  Lines       22443    22443           
  Branches     5381     5381           
=======================================
  Hits        20058    20058           
  Misses       1639     1639           
  Partials      746      746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pp-mo pp-mo closed this Aug 15, 2023
@pp-mo pp-mo reopened this Aug 15, 2023
Copy link
Contributor

@HGWright HGWright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We believe the RTD failiure is a one off and we can't run again off of this PR. We are going to merge and make sure this it works on the next PR before the 3.7 release.

@pp-mo pp-mo merged commit 8361532 into SciTools:main Aug 16, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

2 participants