Frozen user occasionnaly gets treated as a revoked user

[vxgmichel]

For instance:

parsec-cloud/server/parsec/components/postgresql/vlob_update.py

Lines 206 to 212 in d3505ad

	match row["user_is_frozen"]:
	case False:
	pass
	case True:
	return VlobUpdateBadOutcome.AUTHOR_REVOKED
	case unknown:
	assert False, repr(unknown)

This can be fixed by adding a corresponding VlobUpdateBadOutcome.AUTHOR_FROZEN outcome, although this is adding more noise for very little gain. Instead, it is enough to check this status in the authentication layer. This is already done and returning the correct 462 HTTP status.

Note that there is a cache mechanism for the authenticated info, although the cache gets cleared in a user gets frozen, so it shouldn't be a problem.

[FirelightFlagboy]

@touilleMan, can you confirm or not if this code block should be removed ?

[mmmarcos]

Discussed today: yes, this code should be removed. @touilleMan also suggests to add a comment in the revoked case to explain that frozen state is already checked on authentication.