Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #1

wants to merge 1 commit into from

Conversation

omarjmh
Copy link

@omarjmh omarjmh commented Oct 8, 2018

I just took a look at your repro repo, there are a couple critical pieces missing:

  • missing package.json(s) at application level
  • nested workspaces cannot be found because of the above
  • no yarn.lock file -> nothing's gonna work without this.

Steps to fix:

  • update .yarnrc, only needs --ignore-engines
  • add package.json to each 'application'
  • no need to use no hoist here! it can be removed.

helpful commands to try:

yarn outdated (nicer logs)

yarn workspaces info (lists all workspaces)

If its not a workspace (no package.json) yarn cant do what it does. The lock file is important in resolving hoisted/non-hoisted dependencies.

fix
I just took a look at your repro repo, there are a couple critical pieces missing:

- missing package.json(s) at application level
- nested workspaces cannot be found because of the above
- no yarn.lock file -> nothing's gonna work without this.

Steps to fix:

- update .yarnrc, only needs --ignore-engines
- add package.json to each 'application'
- no need to use no hoist here! it can be removed.

helpful commands to try:

yarn outdated (nicer logs)

yarn workspaces info (lists all workspaces)

If its not a workspace (no package.json) yarn cant do what it does. The lock file is important in resolving hoisted/non-hoisted dependencies.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant