Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SemanticSignup to use AuthManager (MW 1.27+) #29

Open
kghbln opened this issue Jun 13, 2016 · 6 comments
Open

Update SemanticSignup to use AuthManager (MW 1.27+) #29

kghbln opened this issue Jun 13, 2016 · 6 comments
Labels

Comments

@kghbln
Copy link
Member

kghbln commented Jun 13, 2016

This extension is also affected by the AuthManager. A respective task was created at Phabricator.

@kghbln kghbln added the bug label Jun 13, 2016
@kghbln
Copy link
Member Author

kghbln commented Jun 16, 2016

See also this related comment so this extension is definitively broken for MW 1.27+. Probably "composer.json" should be adapted accordingly for now.

@kghbln
Copy link
Member Author

kghbln commented Jun 16, 2016

So things are probably not as bad as anticipated.

@Joeytje50
Copy link

Isn't the fix for this bug as simple as modifying src/SpecialSemanticSignup.php to reflect the changes in $wgAuth and AuthPlugin? This does not seem so difficult to "translate" from the old syntax to this new one, so I'm a bit hesitant to perform these conversions myself, considering this bug has been open for quite a while already without anyone doing this seemingly simple task of performing conversions to the new syntax.

If this is indeed the fix for this bug, I'd be willing to go through each of the changes. I still would not be able to test its effectiveness in MW1.27+ though, because of bug #30.

@kghbln
Copy link
Member Author

kghbln commented Apr 18, 2017

To my experience simple conversions end up in disaster so I do not dare to try doing this. Mixing in #30 indeed complicates the whole process. Both tasks are up for grabs.

@mwjames
Copy link
Contributor

mwjames commented Apr 22, 2017

so I'm a bit hesitant to perform these conversions myself, considering this bug has been open for quite a while already without anyone doing this seemingly simple task of performing conversions to the new syntax.

@Joeytje50 Give it a shot if you think you can do it.

I still would not be able to test its effectiveness in MW1.27+ though, because of bug #30.

I'm not up to speed as to what PF requires but it seems @gesinn-it has an understanding of what makes something PF compliant.

@kevindank
Copy link

Is there any update to this? Would love to use SSU on my site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants