Que chille #121
Merged
Que chille #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o, and anio fields
…ajes-de-error' into dev
This commit removes the "id" field from the Alumno model and alters the "dni" and "legajo" fields. The "id" field is no longer needed as it is automatically generated by Django. The "dni" field is now set as the primary key, and the "legajo" field is set as unique. These changes improve the data structure and integrity of the Alumno model.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Cookies.set('refresh_token', data.refresh); | ||
| Cookies.set('access_expiration', data.access_expiration); | ||
| Cookies.set('refresh_expiration', data.refresh_expiration); | ||
| Cookies.set('username', data.user.username); | ||
| Cookies.set('username', data.user.dni); |
Check warning
Code scanning / CodeQL
Clear text transmission of sensitive cookie Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 months ago
To fix the problem, we need to ensure that the username cookie, along with other cookies, is only transmitted over HTTPS. This can be achieved by setting the secure attribute when setting the cookies. Additionally, it is a good practice to set the httpOnly attribute to prevent client-side scripts from accessing the cookies, further enhancing security.
- Modify the
Cookies.setcalls to include thesecureandhttpOnlyattributes. - Ensure that all cookies set in the
FetchLoginfunction are updated accordingly.
Suggested changeset
1
FrontAdmin/src/API/Login.ts
| @@ -17,7 +17,7 @@ | ||
| console.log(data); | ||
| Cookies.set('tokennn', data.access); | ||
| Cookies.set('refresh_token', data.refresh); | ||
| Cookies.set('access_expiration', data.access_expiration); | ||
| Cookies.set('refresh_expiration', data.refresh_expiration); | ||
| Cookies.set('username', data.user.dni); | ||
| Cookies.set('tokennn', data.access, { secure: true, httpOnly: true }); | ||
| Cookies.set('refresh_token', data.refresh, { secure: true, httpOnly: true }); | ||
| Cookies.set('access_expiration', data.access_expiration, { secure: true, httpOnly: true }); | ||
| Cookies.set('refresh_expiration', data.refresh_expiration, { secure: true, httpOnly: true }); | ||
| Cookies.set('username', data.user.dni, { secure: true, httpOnly: true }); | ||
| return data; |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.