Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add slapCommand to bring back the IRC vibe of trout slapping #1056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ADKaster
Copy link
Member

Also update to latest discord.js

@ADKaster
Copy link
Member Author

@bgianfo @networkException halp, running yarn update discord.js (to get the latest nickname resolution changes from ~last year) is requesting node 18? How do I safely update discord.js and/or the CI/production bot?

@networkException
Copy link
Member

networkException commented May 12, 2024

uhh the thing is not stateful, right? not too much should go wrong. According to the docs updating the engines filed in the package.json should be enough (and it should already be on 20.x).

You might also have to adjust node versions in various github action workflows

@ADKaster ADKaster force-pushed the slap-command branch 2 times, most recently from c4bd092 to 1976760 Compare May 12, 2024 22:58
@ADKaster
Copy link
Member Author

it should already be on 20.x

Not according to this commit. 3c5e0ab
Looks like we pinned it to 18.17.1 due to some node-gyp error in the heroku install or something?

@networkException
Copy link
Member

ah hm :/

@bgianfo
Copy link
Member

bgianfo commented May 13, 2024

I can add you to the heroku users so you can try to deploy this and rollback if it fails. Unfortunately there isn't a great way to try it out without creating a dev environment to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants