on import link extensions make absolute urls relative #4877
+98
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonso-noriega
force-pushed
the
admin-link-import-transform-url-to-relative
branch
7 times, most recently
from
1b3a211
to
ae2e639
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/app/src/cli/services/admin-link/extension-to-toml.test.ts
Outdated
Show resolved
Hide resolved
alfonso-noriega
force-pushed
the
admin-link-import-transform-url-to-relative
branch
2 times, most recently
from
b2d26db
to
bd01c9b
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success1947 tests passing in 885 suites. Report generated by 🧪jest coverage report action from 83ee53c |
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
alfonso-noriega
force-pushed
the
admin-link-import-transform-url-to-relative
branch
from
bd01c9b
to
5297a9c
Compare
alfonso-noriega
force-pushed
the
admin-link-import-transform-url-to-relative
branch
7 times, most recently
from
95ec4f0
to
2a816ca
Compare
alfonso-noriega
force-pushed
the
admin-link-import-transform-url-to-relative
branch
from
2a816ca
to
83ee53c
Compare
|
/snapit |
|
🫰✨ Thanks @alfonso-noriega! Your snapshot has been published to npm. Test the snapshot by intalling your package globally: pnpm i -g @shopify/[email protected]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The current process to create legacy link extensions in the partners dashboard enables to create non secure and external pointing absolute URLs for embedded apps. Those URLs are later on overwritten by core to point to the shop embedded app URL.
This behaviour fills the DB with incorrect URLs and the new CLI managed admin link extension is avoiding this pattern.
WHAT is this pull request doing?
To reduce friction on the partners migration, this code automatically ignores the domain of the embedded app legacy link extensions and transforms them into relative URLs.
How to test your changes?
From the CLI repo, checkout this branch.
Create a link extension in the partners dashboard with an absolute URL pointing to a random external domain (http://example.org/product).
In the CLI repo run the import extensions command:
pnpm shopify app import-extensions --path path-to-your-appSelect the admin links option
Check the the generated extension toml contains a url like
app://productI've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes