Implement full underline on stylelint polaris in VSCode

[sophschneider]

Fixed by stylelint/vscode-stylelint#358

Right now, failures in VSCode only underline the first letter of the line. This makes it hard to notice/hover over. This is because the endline isn't provided in our custom rules, there are several solutions in this stylelint issue stylelint/stylelint#5694

[sophschneider]

In the stylelint issue I linked above, supposedly selector-no-vendor-prefix is fixed yet in my VSCode it still only underlines one char when I enable this rule.

[sophschneider]

So it looks like the problem is coming from the VSCode Stylelint plugin which is responsible for underlining failures. They actually have a PR up stylelint/vscode-stylelint#358 that is supposed to implement it, but it hasn't been merged yet. It isn't stale, there was activity about 2 weeks ago

[sophschneider]

Once the Stylelint VSCode PR is merged, we will have to add range data (endLine, etc.) to our custom rule reports, then we should have full range underlines!

[BPScott]

Once the Stylelint VSCode PR is merged, we will have to add range data (endLine, etc.) to our custom rule reports, then we should have full range underlines!

It's worth pointing out that you're free to add range data at any point. Stylelint on the command line will make use of it, and then when VSCode adds support it will be leveraged there too. You're not blocked by Stylelint VSCode here.

[github-actions]

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.