Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prism handling for packager tests too #326

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add Prism handling for packager tests too #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,8 @@ pipeline_tests(
pipeline_tests(
"test_corpus_prism",
glob([
# Replace [parser] with other phases to test Prism at that level
# Phases: https://github.com/Shopify/sorbet/blob/prism/docs/internals.md#phases
"testdata/parser/**/*.rb",
"testdata/parser/**/*.exp",
]),
Expand Down
8 changes: 8 additions & 0 deletions test/pipeline_test.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,14 @@ def pipeline_tests(suite_name, all_paths, test_name_prefix, extra_files = [], ta
"disabled": "disabled" in test_name,
"isPackage": True,
}

# Tests that run with Prism parser need to have "_prism" appended to their name
# to differentiate them from the tests that run with Sorbet parser.
# The condition here is only for the packager tests
# Other tests are handled below.
if parser == "prism":
test_name = test_name + "_prism"

tests[test_name] = data
continue

Expand Down
Loading