Warn when Tapioca is executed without Bundler #2075
Conversation
KaanOzkan
force-pushed
the
ko/check-for-bundler
branch
from
43a5f86
to
e9f5265
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
exe/tapioca
Outdated
| unless ENV["BUNDLER_VERSION"] | ||
| puts "Warning: You're running tapioca without Bundler. This isn't recommended and may cause issues."\ | ||
| " Please use the provided binstub through `bin/tapioca` instead." | ||
| end |
There was a problem hiding this comment.
ENV['BUNDLER_VERSION'] is not a reliable indicator of Bundler being active, as it may be unset even when running under Bundler. Two more reliable alternatives are:
- Check
ENV['BUNDLE_GEMFILE'], which Bundler consistently sets - Check
defined?(Bundler)to detect if Bundler is loaded
Either approach would prevent false warnings in valid Bundler environments.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
I'm pretty sure BUNDLER_VERSION will be set https://github.com/rubygems/rubygems/blob/c46bf736318a41354c9e411c127247c764dff4ab/bundler/lib/bundler/shared_helpers.rb#L305
But we can do defined?(Bundler) too.
|
Is it possible to create a CLI test for this? |
KaanOzkan
force-pushed
the
ko/check-for-bundler
branch
from
e9f5265
to
2fc2054
Compare
I tried shelling to tapioca without |
Motivation
Addresses the finding in #1934 (comment)
Implementation
Print a warning as early as possible. Looking at various env variables
BUNDLER_VERSIONfelt like a safe bet.Tests
Tested manually. I can add it if wanted.